Skip to content

Allow pre-releases and fix error message in DIRAC version check #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
maxnoe wants to merge 2 commits into
base: integration
Choose a base branch
from
Open

Allow pre-releases and fix error message in DIRAC version check #771

maxnoe wants to merge 2 commits into from

Conversation

@maxnoe
Copy link

@maxnoe maxnoe commented Jan 15, 2025

BEGINRELEASENOTES
FIX: Allow pre-releases in the DIRAC version check when starting the WebAPP and allow pre-releases for development
ENDRELEASENOTES

@maxnoe maxnoe force-pushed the fix_version_check branch from 7fb289a to 272955a Compare January 26, 2026 15:02
@maxnoe maxnoe changed the base branch from rel-v5r0 to integration January 26, 2026 15:02
@maxnoe maxnoe force-pushed the fix_version_check branch from 272955a to 1a6546c Compare January 26, 2026 15:06
@fstagni fstagni closed this Jan 26, 2026
@fstagni fstagni reopened this Jan 26, 2026
@maxnoe maxnoe marked this pull request as ready for review January 26, 2026 16:23
@aldbr
Copy link
Contributor

aldbr commented Jan 26, 2026

In the next few days, I will try to run the branch in certification, if it does not break, then I will merge it, thanks!

@fstagni
Copy link
Contributor

fstagni commented Feb 10, 2026

Given that we will not have anymore pre-releases (ever!), I do not think this is needed. Re-open if you think I am wrong.

@fstagni fstagni closed this Feb 10, 2026
@maxnoe
Copy link
Author

maxnoe commented Feb 10, 2026

Given that we will not have anymore pre-releases (ever!), I do not think this is needed. Re-open if you think I am wrong.

The motivation for this change was local development! Where the version is based on the last tag plus some .devXXX git information, aka a pre-release.

It also fixes a genuine bug in the error message.

@maxnoe
Copy link
Author

maxnoe commented Feb 10, 2026

At least the fix for the error message should be taken. I can split if you want, but I think this should go in

@aldbr aldbr reopened this Feb 10, 2026
@fstagni
Copy link
Contributor

fstagni commented Feb 10, 2026

Given that we will not have anymore pre-releases (ever!), I do not think this is needed. Re-open if you think I am wrong.

The motivation for this change was local development! Where the version is based on the last tag plus some .devXXX git information, aka a pre-release.

It also fixes a genuine bug in the error message.

Ah, sorry about that. Re-opened then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

sweep:ignore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maxnoe @aldbr @fstagni @DIRACGridBot